Re: [PATCH 1/1] PCI: replace chan->device->dev with dmaengine_get_provider_device()

[Andy Shevchenko]

On Tue, Nov 03, 2026 at 04:29:20PM -0500, Frank.Li@xxxxxxxxxxx wrote:
> 
> Use the dmaengine_get_provider_device() API instead of directly
> accessing chan->device->dev to get the DMA provider device.
> 
> No functional change. Prepare make to struct dma_device private to the DMA
> engine.

...

>  Assisted-by: LLM

It's an obsolete tag. Please, replace it in a free-form explanation how AI was
used in the comment block, below '---' line.

> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---

...

> static bool pci_epf_mhi_filter(struct dma_chan *chan, void *node)

>  	memset(&caps, 0, sizeof(caps));
>  	dma_get_slave_caps(chan, &caps);
>  
> -	return chan->device->dev == filter->dev && filter->dma_mask &
> +	return dmaengine_get_provider_device(chan) == filter->dev && filter->dma_mask &
>  					caps.directions;

While at it, fix indentation:

	return dmaengine_get_provider_device(chan) == filter->dev &&
	       (filter->dma_mask & caps.directions);

...

> static bool epf_dma_filter_fn(struct dma_chan *chan, void *node)

>  	memset(&caps, 0, sizeof(caps));
>  	dma_get_slave_caps(chan, &caps);
>  
> -	return chan->device->dev == filter->dev
> +	return dmaengine_get_provider_device(chan) == filter->dev
>  		&& (filter->dma_mask & caps.directions);

Ditto.

	return dmaengine_get_provider_device(chan) == filter->dev &&
	       (filter->dma_mask & caps.directions);

...

Looking more at it, you probably want to deduplicate this code at some point.


-- 
With Best Regards,
Andy Shevchenko