Re: [PATCH RESEND v7 2/2] input: misc: Add Qualcomm SPMI PMIC haptics driver

[Krzysztof Kozlowski]

On Tue, Nov 03, 2026 at 08:51:18PM -0800, Fenglin Wu wrote:
> Add an initial driver for the Qualcomm PMIH0108 PMIC haptics module,
> named as HAP530_HV. This module supports several play modes, including
> DIRECT_PLAY, FIFO, PAT_MEM, and SWR, each with distinct data sourcing
> and hardware data handling logic. Currently, the driver provides support
> for two play modes using the input force-feedback framework: FF_CONSTANT
> effect for DIRECT_PLAY mode and FF_PERIODIC effect with FF_CUSTOM
> waveform for FIFO mode.
> 
> Assisted-by: Claude:claude-4-8-opus
> Signed-off-by: Fenglin Wu <fenglin.wu@xxxxxxxxxxxxxxxx>
> ---
>  drivers/input/misc/Kconfig             |   11 +
>  drivers/input/misc/Makefile            |    1 +
>  drivers/input/misc/qcom-spmi-haptics.c | 1251 ++++++++++++++++++++++++++++++++

Fails checkpatch, does not apply, Sashiko comments.

Resending buggy code will not make it better.

Best regards,
Krzysztof