Re: [PATCH v10 08/11] dt-bindings: ufs: Add NXP S32N79 UFS host controller
From: Larisa Ileana Grigore
Date: Wed Nov 04 2026 - 04:41:29 EST
On 11/4/2026 10:40 AM, Krzysztof Kozlowski wrote:
On 04/11/2026 09:38, Krzysztof Kozlowski wrote:
On Tue, Nov 03, 2026 at 02:32:12PM +0100, Larisa Grigore wrote:
Document the UFS host controller on the NXP S32N79 SoC.
The S32N79 M-PHY has two data lanes per direction and the driver programs
both of them, so restrict lanes-per-direction to 2.
The UFS core manages only the clocks added by the platform glue. Since
freq-table-hz is deprecated, the binding requires operating-points-v2 and
clock-names. As S32N79 does not scale the UFS clock, the OPP table contains
a single 0 Hz entry, which keeps the provider-configured rate while
allowing the clock to be enabled and gated.
Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
Signed-off-by: Larisa Grigore <larisa.grigore@xxxxxxxxxxx>
No lore links in the changelog and b4 diff:
b4 diff '20261103133215.1385823-1-larisa.grigore@xxxxxxxxxxx'
Looking up 20261103133215.1385823-1-larisa.grigore@xxxxxxxxxxx
Checking for older revisions
Grabbing search results from lore.kernel.org
---
Analyzing 91 messages in the thread
Could not find lower series to compare against.
Is NXP going to switch to b4 or not? How many times this can be raised?
Sure, you do not have to switch, but then why is `b4 diff` not working
on your patchset?
Dropping from DT patchwork.
Ah, found now v8 and previous feedback was not responded to, nor addressed.
Best regards,
Krzysztof
Hi Krzysztof,
Sorry for the confusion, and for not replying earlier.
The series sent on 24 Oct as "v1" was meant to be v9. It went out with the wrong version number, which is also why b4 diff could not find the previous revision. The revisions are:
v8: https://lore.kernel.org/all/20261013103003.373156-1-larisa.grigore@xxxxxxxxxxx/
v9: https://lore.kernel.org/all/20261024122533.3609180-1-larisa.grigore@xxxxxxxxxxx/
v10: https://lore.kernel.org/all/20261103133215.1385823-1-larisa.grigore@xxxxxxxxxxx
Regarding your comments on v9:
Frank's Reviewed-by was given publicly on v8 [1]. The series only looked like a v1 because of the wrong version number.
The tag ordering was changed in v10 since the patch was changed.
The single 0 Hz OPP entry: as discussed on v8 [2][3], the clock rate is set outside Linux and is not scaled. The OPP table lets the UFS core enable and gate the clock. As you suggested, v10 explains this in the commit message. Let me know if you would like more details there.
For the next revision, I will add lore links to all previous versions in the changelog and switch to b4, so that b4 diff works.
[1] https://lore.kernel.org/all/as4_lVm9tvTeOkBp@SMW015318/
[2] https://lore.kernel.org/all/fa3a025b-0d82-42df-a4cc-e144d6a97b20@xxxxxxxxxxx/
[3] https://lore.kernel.org/all/20261015-observant-nickel-monkey-2a38b7@quoll/
Best regards, Larisa