Re: [PATCH v10 08/11] dt-bindings: ufs: Add NXP S32N79 UFS host controller

From: Krzysztof Kozlowski

Date: Thu Nov 05 2026 - 13:28:29 EST


On 04/11/2026 10:41, Larisa Ileana Grigore wrote:
> On 11/4/2026 10:40 AM, Krzysztof Kozlowski wrote:
> v8:
> https://lore.kernel.org/all/20261013103003.373156-1-larisa.grigore@xxxxxxxxxxx/
> v9:
> https://lore.kernel.org/all/20261024122533.3609180-1-larisa.grigore@xxxxxxxxxxx/
> v10:
> https://lore.kernel.org/all/20261103133215.1385823-1-larisa.grigore@xxxxxxxxxxx
>
> Regarding your comments on v9:
>
> Frank's Reviewed-by was given publicly on v8 [1]. The series only looked
> like a v1 because of the wrong version number.
> The tag ordering was changed in v10 since the patch was changed.
> The single 0 Hz OPP entry: as discussed on v8 [2][3], the clock rate is
> set outside Linux and is not scaled. The OPP table lets the UFS core

That is not the purpose of OPP table. OPP defines performance point.
Performance point of 0 makes no sense. You cannot use Linux limitations
as reason to add some DTS, because answer is simple: fix your Linux
limitations.

> enable and gate the clock. As you suggested, v10 explains this in the
> commit message. Let me know if you would like more details there.



Best regards,
Krzysztof