Re: [PATCH v2] firmware: xilinx: Request pre-allocated peripheral nodes after bulk release

[Michal Simek]

On 10/19/26 12:21, Jay Buddhabhatti wrote:
> During a kexec restart, zynqmp_clear_pm_state() releases all peripheral
> devices via PM_DEV_ALL_PERIPH. Pre-allocated nodes are then left released,
> so Linux no longer owns them and later peripheral access can fail.
>
> Immediately re-request those nodes with zynqmp_pm_request_node(
> PM_DEV_ALL_PERIPH, ...) so Linux retains ownership. On a graceful kexec
> this runs from zynqmp_firmware_shutdown(). On a crash kernel restart it
> runs from zynqmp_firmware_probe() in the reloaded kernel.
>
> The bulk request depends on firmware support for PM_DEV_ALL_PERIPH
> (PM_REQUEST_NODE feature check version >= PM_API_VERSION_3). On firmware
> that does not implement it, the request is skipped and a warning is
> logged. Errors are already logged inside zynqmp_clear_pm_state() and
> zynqmp_firmware_probe() does not abort if the request fails.
>
> Also, drop the redundant ret = 0 assignments whose value is overwritten
> by the next do_feature_check_call()
>
> Fixes: 84dbfa5519cf ("firmware: xilinx: Release all peripheral devices from firmware")
> Signed-off-by: Jay Buddhabhatti <jay.buddhabhatti@xxxxxxx>
> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx>
> ---
> Changes in v2:
>    - Add Fixes tag for the bulk peripheral release commit.
>    - Add Reviewed-by from Radhey Shyam Pandey (v1 review).
>
> Link: https://lore.kernel.org/r/20260923100343.3147243-1-jay.buddhabhatti@xxxxxxx/
> ---
>   drivers/firmware/xilinx/zynqmp.c | 15 +++++++++++++--
>   1 file changed, 13 insertions(+), 2 deletions(-)
Applied.
M