Re: [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc
From: Maxime Chevallier
Date: Wed Nov 04 2026 - 06:34:12 EST
Hi Jonathan,
On 11/1/26 00:48, Jonathan Cameron wrote:
> On Fri, 30 Oct 2026 17:47:04 +0100
> Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx> wrote:
>
>> Add a new driver for the TI TLA2528 ADC chip. It has 8 12-bit
>> channels, that can also be configured as 16-bit averaging channels.
>>
>> This is a very simple driver, allowing reading raw values for each
>> channel. GPIO mode isn't supported for now, as well as buffered mode and
>> the 16-bit averaging mode.
>>
>> Co-developed-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
>> Signed-off-by: Rodolfo Giometti <giometti@xxxxxxxxxxxx>
>> Signed-off-by: Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>
> Hi Maxime
>
> A couple of minor things inline. At least one due to cleanup
> that happened tree wide in the last year.
>
Thanks a lot for your reviews, I'll address those in V3, I don't have
any objections on them, it's all clear and straightforward :)
Same goes for Matti, Victor and Rodolfo's comments, I'll just keep the
Kconfig help message consistent with other drivers.
Thanks,
Maxime