Re: [PATCH net] can: j1939: fix skb refcount underflow in session teardown paths

[Tristan Madani]

From: Tristan Madani <tristan@xxxxxxxxxxxxxxxxxxx>

On Wed, 04 Nov 2026, netdev-bot+sashiko@xxxxxxxxxx wrote:
> [Severity: Critical]
> Does this leak every skb on session->skb_queue?

Yes, this is correct.  Queued skbs carry refcount 2 (one from the
allocation and one from skb_get in j1939_session_new /
j1939_session_skb_queue), so the existing skb_unref + kfree_skb
sequence is the intended teardown path.  Removing skb_unref would
leave every skb at refcount 1 after kfree_skb, leaking it.

Withdrawing this patch.

pw-bot: cr