Re: [PATCH] pinctrl: nsp: support both-edge GPIO interrupts

[Linus Walleij]

On Wed, Oct 21, 2026 at 8:37 PM Florian Fainelli
<florian.fainelli@xxxxxxxxxxxx> wrote:

> The SFP core requests rising and falling edge interrupts for module
> presence, loss of signal and transmit fault GPIOs. GPIO-A only has one
> edge polarity bit per pin, so the driver rejects IRQ_TYPE_EDGE_BOTH and
> makes the SFP core fall back to polling.
>
> Emulate both-edge detection by arming the edge opposite to the current
> input level, then rearm it after acknowledging each interrupt and before
> unmasking. Resample the input while programming the polarity so an edge
> during that sequence leaves the controller armed for the new level.
>
> Fixes: 8bfcbbbcabe0 ("pinctrl: nsp: add gpio-a driver support for Broadcom NSP SoC")
> Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

Patch applied as nonurgent fix, tell me if it's actually urgent so it needs
to go into the -rc:s.

Yours,
Linus Walleij