Re: [PATCH v3 3/3] drm/vc4: dpi: inline vc4_dpi_init_bridge() into vc4_dpi_bind()

From: Luca Ceresoli

Date: Thu Nov 05 2026 - 05:03:09 EST


Hi Maíra,

On Sat Oct 24, 2026 at 3:03 PM CEST, Maíra Canal wrote:
> Hi Luca,
>
> If you go ahead with this patch, could you merge it with [1/3]
> Personally, I prefer to keep it as a separate function. vc4_dpi_bind()
> is already a big function, with several initializations. I have the
> impression that vc4_dpi_init_bridge() makes the error handling more
> clear.

I agree, and that's why this inlining was not in my initial work. It was
suggested by Paul, but since there are other opinions against it I'll just
drop this patch.

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com