Re: [PATCH 1/7] wifi: brcmfmac: match firmware capabilities as whole words

[Arend van Spriel]

Op 4 november 2026 16:15:51 schreef Andre Eikmeyer <dev@deq.rocks>:

> brcmf_feat_firmware_capabilities() looks for each capability with
> strnstr() in the space separated reply of the "cap" iovar, so a
> capability matches inside a longer one. The Apple firmware for the
> BCM4364 lists "hp2p" but not "p2p":
>
>  ... evt_ext lpr_scan bkoff_evt hp2p rng_reseed arpoe
>
> The driver still sets BRCMF_FEAT_P2P and advertises the P2P interface
> types. wpa_supplicant then creates a P2P device, which fails because
> the firmware rejects p2p_disc and p2p_da_override with
> BCME_UNSUPPORTED:

[...]

> Fixes: ec64241c9fd2 ("brcmfmac: obtain feature info using 'cap' firmware 
> command")
> Reported-by: Aditya Garg <aditya.garg@xxxxxxxxx>
> Closes: 
> https://lore.kernel.org/all/MA0P287MB021718EE92FC809CB2BB0F82B8BD2@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/
> Tested-by: Yossef Osman <Yossef.Osman@xxxxxxxxx>
> Tested-by: Aditya Garg <aditya.garg@xxxxxxxxx>
> Signed-off-by: Andre Eikmeyer <dev@deq.rocks>

Nearly identical patch was already accepted in the 4388 support series. 
Dropping this one.

Regards,
Arend

> ---
> .../wireless/broadcom/brcm80211/brcmfmac/feature.c | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c 
> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
> index cc19e5e7ebf..b324eb53a69 100644
> ---