Re: [PATCH v1 1/1] arm64: dts: freescale: Move Variscite Ethernet LEDs to carrier boards

[Frank Li]

On Thu, Nov 05, 2026 at 06:44:39PM +0100, Stefano Radaelli wrote:
> On Thu, Nov 05, 2026 at 11:34:49AM -0600, Frank Li wrote:
> > On Thu, Nov 05, 2026 at 11:17:39AM +0100, Stefano Radaelli wrote:
> > > From: Stefano Radaelli <stefano.r@xxxxxxxxxxxxx>
> > >
> > > The Ethernet LEDs are physically on the carrier boards, but the
> > > VAR-SOM-MX8MP, DART-MX91, VAR-SOM-MX93 and DART-MX95 module descriptions
> > > include their LED nodes. Other carriers therefore inherit LED definitions
> > > that may not match their wiring.
> >
> > what's impact?
> >
>
> Hi Frank,
>
> There are two main points:
>
> 1. The SOM dtsi is intended to be reused with different carriers.
>    Defining the LEDs there forces every carrier to inherit the reference
>    board’s LED configuration. Customers then have to override those
>    definitions or explicitly delete the LED nodes if their carrier has no LEDs.
>    Keeping the definitions in the carrier DTS avoids requiring customers
>    to undo configuration for hardware that is not part of the SoM.
>
> 2. The Ethernet connectors, LEDs and their wiring are on the carrier.
>    Their definitions therefore belong in the carrier DTS, while the SOM dtsi
>    should describe the hardware on the module.
>    This change makes that separation consistent across our boards.
>
> There is no functional change for the existing Symphony and Sonata boards:
> their final device trees retain the same LED configuration.

If not impact for current user, needn't fix tags to back port it.

Frank

>
> Thank you Frank,
> Best Regards,
> Stefano