Re: [PATCH v5 1/2] dt-bindings: iio: adc: Add the Ingenic X1600 ADC

[H. Nikolaus Schaller]

> Am 06.11.2026 um 09:11 schrieb Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
> 
> On 06/11/2026 09:05, H. Nikolaus Schaller wrote:
>> 
>> 
>>> Am 06.11.2026 um 08:05 schrieb Krzysztof Kozlowski <krzk@xxxxxxxxxx>:
>>> 
>>> On 05/11/2026 22:32, Olivier Louvignes wrote:
>>>> The X1600's SAR ADC has four auxiliary channels and none of the
>>>> touchscreen or battery engines of the JZ47xx ADCs in ingenic,adc.yaml,
>>>> so it gets a binding of its own.
>>>> 
>>>> Signed-off-by: Olivier Louvignes <olivier@xxxxxxxxx>
>>>> Tested-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> # LX16 - driver only, no real world test
>>> 
>>> Drop, did not happen. Even comment says it did not happen!
>> 
>> What did not happen? Are you expecting a software test or a full hardware test?
> 
> Testing of this patch did not happen.
> 
>> 
>>> 
>>> Otherwise please explain me how this code was executed on a device.
>> 
>> 1. add decive tree entries, 2. compile, 3. install, 4. boot and load module, 5. check sysfs
> 
> And none of above is in this patch, so you just confirmed this patch was
> not tested.

???

Sorry but I can't follow you here..

> 
> Again, please drop inaccurate tag from this patch.

Ah, on third thought I start to understand...

Because you look at *this* patch in isolation while I looked at the whole
series.

Yes, you are right - the dt-bindings is not directly tested (indirectly it 
was because I copied the example from this patch into my device tree and
it worked). Then, the ADC driver was tested (but not the hardware).

So this tag should not simply be dropped but moved to the driver code.

BR and thanks,
Nikolaus