Re: [PATCH v5 1/2] dt-bindings: iio: adc: Add the Ingenic X1600 ADC

[Krzysztof Kozlowski]

On 06/11/2026 09:18, H. Nikolaus Schaller wrote:
>>
>> Again, please drop inaccurate tag from this patch.
> 
> Ah, on third thought I start to understand...
> 
> Because you look at *this* patch in isolation while I looked at the whole
> series.

I did not comment under the driver patch, nor under the cover letter. I
placed my comment in specific context - this patch touching the
bindings, because you cannot test bindings on a device.


> 
> Yes, you are right - the dt-bindings is not directly tested (indirectly it 
> was because I copied the example from this patch into my device tree and
> it worked). Then, the ADC driver was tested (but not the hardware).
> 
> So this tag should not simply be dropped but moved to the driver code.
Yes, please. Thank you for testing, it is important and should be
credited, just accordingly.


Best regards,
Krzysztof