Re: [PATCH net-next] net: bgmac: stop advertising TX checksum offload

[Simon Horman]

On Mon, Nov 02, 2026 at 01:58:06PM -0800, Rosen Penev wrote:
> The driver advertises NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM, but
> bgmac_dma_tx_add() calls skb_checksum_help() on every CHECKSUM_PARTIAL
> skb, so the checksum is always computed in software anyway. The return
> value is ignored too, so if skb_checksum_help() fails the frame is sent
> with a bad checksum.
> 
> Remove the feature flags and the fallback. The stack then computes the
> checksum before handing the skb to the driver.
> 
> Tested on an ASUS RT-N16.
> 
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>