Re: [PATCH net-next] net: bgmac: stop advertising TX checksum offload

[Florian Fainelli]

On 11/2/2026 1:58 PM, Rosen Penev wrote:
> The driver advertises NETIF_F_IP_CSUM and NETIF_F_IPV6_CSUM, but
> bgmac_dma_tx_add() calls skb_checksum_help() on every CHECKSUM_PARTIAL
> skb, so the checksum is always computed in software anyway. The return
> value is ignored too, so if skb_checksum_help() fails the frame is sent
> with a bad checksum.
>
> Remove the feature flags and the fallback. The stack then computes the
> checksum before handing the skb to the driver.
>
> Tested on an ASUS RT-N16.
>
> Signed-off-by: Rosen Penev <rosenp@xxxxxxxxx>

Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>

There is no transmit checksum offload through the DMA descriptors, it 
can only be done through FA/FA+ which is not supported yet (working on 
that).
--
Florian