Re: [PATCH net-next 1/3] net: sb1250-mac: Add ethtool link settings support

[Daniel Machon]

> The driver connects to its PHY through phylib, but does not provide
> ethtool operations. As a result, ethtool cannot report or configure the
> link settings.
> 
> Use the phylib get_link_ksettings and set_link_ksettings helpers, and
> provide ethtool_op_get_link for carrier reporting. The helpers return
> -ENODEV when the PHY is not attached, as the driver attaches it when
> the interface is opened and disconnects it when the interface is closed.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Reviewed-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>