Re: [PATCH net-next 1/3] net: sb1250-mac: Add ethtool link settings support

From: Maciej W. Rozycki

Date: Thu Nov 05 2026 - 18:14:15 EST


On Thu, 5 Nov 2026, Florian Fainelli wrote:

> Use the phylib get_link_ksettings and set_link_ksettings helpers, and
> provide ethtool_op_get_link for carrier reporting. The helpers return
> -ENODEV when the PHY is not attached, as the driver attaches it when
> the interface is opened and disconnects it when the interface is closed.

Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxx>

(I should probably list myself as a maintainer for all the SB1250 platform
stuff since I've done most of the updates in the last two decades or so.)

Maciej