Re: [PATCH v4 00/13] mm: Decouple folio-based vmemmap optimization from HugeTLB

[Andrew Morton]

On Sat,  7 Nov 2026 10:27:43 +0800 Muchun Song <songmuchun@xxxxxxxxxxxxx> wrote:

> Hi,
> 
> Section-based vmemmap optimization is implemented in sparse-vmemmap.c,
> while folio-based optimization currently lives in hugetlb_vmemmap.c.
> The latter is tightly coupled to HugeTLB-specific state even though the
> underlying page-table remapping operates on one folio at a time.
> 
> To make these interfaces easier to maintain, the folio-based remapping
> mechanics first need a boundary that is independent of HugeTLB-specific
> state and raw address ranges. This will allow the mechanics to be moved
> into a common vmemmap optimization layer alongside the section-based
> interface.
> 
> This series establishes that boundary through three folio-oriented
> operations, each with a distinct role:
> 
>   - vmemmap_optimize_folio() optimizes the vmemmap backing of a folio;
>   - vmemmap_restore_folio() restores the vmemmap backing of a folio; and
>   - vmemmap_pteify_folio() converts the vmemmap backing of a folio to
>     PTE mappings.
> 
> Together, these operations encapsulate the address-range calculation and
> remapping mechanics for a folio. HugeTLB wrappers retain policy decisions
> such as eligibility, optimized state, batching and TLB flush handling.

Thanks, I've update mm.git's mm-unstable branch to this version.

> v4:
> - Rebase onto mm/mm-new at f735a2c21aa9
> - Split the HVO head-page allocation fix into a standalone prerequisite
>   and retain Yili Zhang as its author
> - Add __GFP_NOWARN and pass caller-selected GFP masks through the
>   generalized allocator and folio-oriented helpers
> - Propagate alloc_vmemmap_page_list() errors directly (suggested by Oscar
>   Salvador)
> - Remove the redundant order check from vmemmap_pteify_folio() (suggested
>   by Oscar Salvador)
> - Collect Reviewed-by tags from Oscar Salvador and Mike Rapoport
> - Collect Tested-by from Andrew Morton

Here's how v4 altered mm.git:


 mm/hugetlb_vmemmap.c |   32 +++++++++++++++++---------------
 1 file changed, 17 insertions(+), 15 deletions(-)

--- a/mm/hugetlb_vmemmap.c~b
+++ a/mm/hugetlb_vmemmap.c
@@ -198,13 +198,13 @@ static void free_vmemmap_page_list(struc
 }
 
 static int alloc_vmemmap_page_list(struct list_head *head,
-		unsigned int nr_pages, int nid)
+		unsigned int nr_pages, int nid, gfp_t gfp_mask)
 {
-	LIST_HEAD(new_pages);
 	struct page *page, *next;
+	LIST_HEAD(new_pages);
 
 	for (unsigned int i = 0; i < nr_pages; i++) {
-		page = alloc_pages_node(nid, GFP_KERNEL | __GFP_RETRY_MAYFAIL, 0);
+		page = alloc_pages_node(nid, gfp_mask | __GFP_RETRY_MAYFAIL, 0);
 		if (!page)
 			goto free_pages;
 		list_add(&page->lru, &new_pages);
@@ -312,14 +312,11 @@ static inline int vmemmap_restore_range(
  */
 static int vmemmap_pteify_folio(const struct folio *folio, unsigned long flags)
 {
+	unsigned long start = (unsigned long)folio_page(folio, 0);
+	unsigned long end = start + folio_vmemmap_size(folio);
 	struct vmemmap_remap_walk walk = {
 		.flags		= flags,
 	};
-	unsigned long start = (unsigned long)folio_page(folio, 0);
-	unsigned long end = start + folio_vmemmap_size(folio);
-
-	if (!vmemmap_optimizable_order(folio_order(folio)))
-		return -EOPNOTSUPP;
 
 	return vmemmap_remap_range(start, end, &walk);
 }
@@ -341,9 +338,10 @@ static int vmemmap_pteify_folio(const st
 static int vmemmap_optimize_folio(const struct folio *folio,
 		struct list_head *vmemmap_pages, unsigned long flags)
 {
-	int ret, nid = folio_nid(folio);
 	unsigned long start = (unsigned long)folio_page(folio, 0);
 	unsigned long end = start + folio_vmemmap_size(folio);
+	gfp_t gfp_mask = GFP_KERNEL | __GFP_NOWARN;
+	int ret, nid = folio_nid(folio);
 	struct vmemmap_remap_walk walk = {
 		.remap_pte	= vmemmap_optimize_pte,
 		.vmemmap_pages	= vmemmap_pages,
@@ -355,8 +353,10 @@ static int vmemmap_optimize_folio(const
 	if (!vmemmap_optimizable_order(folio_order(folio)))
 		return -EOPNOTSUPP;
 
-	if (alloc_vmemmap_page_list(vmemmap_pages, VMEMMAP_OPTIMIZATION_PAGES, nid))
-		return -ENOMEM;
+	ret = alloc_vmemmap_page_list(vmemmap_pages, VMEMMAP_OPTIMIZATION_PAGES,
+				      nid, gfp_mask);
+	if (ret)
+		return ret;
 
 	ret = vmemmap_remap_range(start, end, &walk);
 	if (!ret || !walk.nr_walked)
@@ -381,14 +381,16 @@ static int vmemmap_optimize_folio(const
  */
 static int vmemmap_restore_folio(const struct folio *folio, unsigned long flags)
 {
-	LIST_HEAD(vmemmap_pages);
-	int nid = folio_nid(folio);
 	unsigned long start = (unsigned long)folio_page(folio, 0);
 	unsigned long end = start + folio_vmemmap_size(folio);
+	int ret, nid = folio_nid(folio);
+	LIST_HEAD(vmemmap_pages);
 
 	start += VMEMMAP_OPTIMIZATION_SIZE;
-	if (alloc_vmemmap_page_list(&vmemmap_pages, (end - start) / PAGE_SIZE, nid))
-		return -ENOMEM;
+	ret = alloc_vmemmap_page_list(&vmemmap_pages, (end - start) / PAGE_SIZE,
+				      nid, GFP_KERNEL);
+	if (ret)
+		return ret;
 
 	return vmemmap_restore_range(start, end, &vmemmap_pages, flags);
 }
_