Re: [PATCH] net: ipa: Fix runtime PM reference leak in ipa_remove()

[Wentao Liang]

Hi Alex,

Sorry for the very late reply, and for the noise.

You are right that this is already fixed, and I should have caught it
before posting.  6b9eaa61ff2df ("net: ipa: balance runtime PM reference on
remove error") makes the same change, and it has been in mainline since
v7.3-rc1.  I rechecked ipa_remove() in the current tree, and that error
path now releases the reference:

			dev_err(dev, "Failed to stop modem (%pe), leaking resources\n",
				ERR_PTR(ret));
			pm_runtime_put_noidle(dev);
			return;

so the usage count is balanced there and there is nothing left to fix.
The patch needs no v2; please disregard it.  The patchwork entry already
shows as not applicable.

You asked how I found the problem.  The candidate came from our static
analysis tooling, which flagged the missing put on that error path.  I
then used DeepSeek and GPT-6.1 Sol to audit the finding and to help write
the change, and I reviewed the result myself before sending it.

What I got wrong is that the diff was prepared from an old snapshot
(v7.1-rc4 based) and I did not check the current tree before posting, so
I missed that the fix had already landed.  That is on me, and I am sorry
for the review time it cost you.

I am going through the outstanding feedback on my patches by hand now,
thread by thread, and will answer each one.

Thanks,
Wentao