Re: [PATCH] net: ipa: Fix enabled_state leak in ipa_smp2p_init()

From: Wentao Liang

Date: Sun Nov 08 2026 - 05:41:35 EST


Hi Alex,

Sorry for the very late reply, and for the noise.

You are right on both points. This is already fixed by 96ca1e658ae45
("net: ipa: fix SMEM state handle leaks in SMP2P init"), which has been
in mainline since v7.2-rc2 and releases both SMEM state handles on the
init error paths and in ipa_smp2p_exit(). My patch is a duplicate, and
on its own it would also have been incomplete: it only handles
enabled_state and leaves ipa_smp2p_exit() untouched. No v2 is needed;
please disregard it.

On where the code came from: the diff was generated from an old snapshot
of the tree (v7.1-rc4 based), not from v7.2, and I did not rebase or
recheck it against the current tree before sending. That is why the
context does not match what v7.2 has now. The candidate itself came from
our static analysis tooling; DeepSeek and GPT-6.1 Sol were used to audit
the finding and to help write the change, and I reviewed the result
myself before sending it. Checking it against the tree of the day was my
job and I skipped it, so I am sorry you spent review time on this.

I am working through the rest of the feedback by hand now.

Thanks,
Wentao