Re: [PATCH] crypto: omap-sham: remove redundant pm_runtime_dont_use_autosuspend() calls

[Joshua Crofts]

On Sat, 07 Nov 2026 13:39:43 +0100
Joshua Crofts <crofts@xxxxxxxxxx> wrote:

> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
> 
> Remove the redundant function calls.
> 
> Signed-off-by: Joshua Crofts <crofts@xxxxxxxxxx>
> ---
>  drivers/crypto/omap-sham.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
> index 5e739415a010..72182f190084 100644
> --- a/drivers/crypto/omap-sham.c
> +++ b/drivers/crypto/omap-sham.c
> @@ -2109,7 +2109,6 @@ static int omap_sham_probe(struct platform_device *pdev)
>  	list_del(&dd->list);
>  	spin_unlock_bh(&sham.lock);
>  err_pm:
> -	pm_runtime_dont_use_autosuspend(dev);
>  	pm_runtime_disable(dev);
>  	if (!dd->polling_mode)
>  		dma_release_channel(dd->dma_lch);
> @@ -2131,7 +2130,6 @@ static void omap_sham_remove(struct platform_device *pdev)
>  	omap_sham_unregister_algs(dd->pdata);
>  	crypto_engine_exit(dd->engine);
>  	cancel_work_sync(&dd->done_task);
> -	pm_runtime_dont_use_autosuspend(&pdev->dev);

Okay, drop this patch for the time being - the dont_use_autosuspend() ensures
that the .runtime_suspend callback is executed.

Thanks.

--
Kind regards,
Joshua Crofts