Re: [PATCH] platform/x86: ayaneo-ec: Enable charge control on Flip KB

[Antheas Kapenekakis]

On Sun, 8 Nov 2026 at 03:04, Hijae Song <hijae99@xxxxxxxxx> wrote:
>
> Flip KB was matched to quirk_fan (fan control only), the same
> quirk used for boards without a working charge-limit EC
> interface. Testing on real hardware shows the charge-limit
> register works identically to AIR/AIR 1S/KUN, so switch it to
> quirk_charge_limit.
>
> Verified on real hardware: switching charge_behaviour to
> inhibit-charge stops the charge current (status: Not charging,
> power_now: 0), and switching back to auto resumes charging.
>

I would have liked a slightly shorter description with the slop "
Verified on real hardware:" cut out, but it is not worth resending.
Ideally dropping the second paragraph, and swapping "real hardware"
with "the device"

Reviewed-by: Antheas Kapenekakis <lkml@xxxxxxxxxxx>

Antheas

> Signed-off-by: Hijae Song <hijae99@xxxxxxxxx>
> ---
>  drivers/platform/x86/ayaneo-ec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/ayaneo-ec.c b/drivers/platform/x86/ayaneo-ec.c
> index 41a24e09..6fe2387d 100644
> --- a/drivers/platform/x86/ayaneo-ec.c
> +++ b/drivers/platform/x86/ayaneo-ec.c
> @@ -88,7 +88,7 @@ static const struct dmi_system_id dmi_table[] = {
>                         DMI_MATCH(DMI_BOARD_VENDOR, "AYANEO"),
>                         DMI_MATCH(DMI_BOARD_NAME, "FLIP"),
>                 },
> -               .driver_data = (void *)&quirk_fan,
> +               .driver_data = (void *)&quirk_charge_limit,
>         },
>         {
>                 .matches = {
> --
> 2.54.0 (Apple Git-157)
>
>