Re: [RESEND PATCH 1/3] power: supply: max17040: pass the device fwnode to the power supply core
From: Hugo Karlsson
Date: Mon Nov 09 2026 - 04:01:28 EST
> Please run scripts/checkpatch.pl on the patches and fix reported
> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
> patches and (probably) fix more warnings.
Thanks, sorry in regards to that. I ran both, the only findings are
for the "Assisted-by: " line, which checkpatch does not recognise
("Non-standard signature" and "Unrecognized email address"); --strict
reports no checks on the code itself
It seems it was removed in 1e035297ffda at the 13 October as Sebasation could just drop it on the applied series, but that´s maybe something I need to do myself and send a patch v2? Or is that just cosmetic?
Hugo
On 09/11/2026 08:30, Krzysztof Kozlowski wrote:
On 08/11/2026 16:42, Hugo Karlsson wrote:
Since commit f4b782af61ae ("power: max17040: pass status property fromIf you are resending, then at least you could run checkpatch.
supplier") the driver forwards POWER_SUPPLY_PROP_STATUS to its supplier,
and the DT binding documents a power-supplies property for naming that
supplier. The driver never passes its device node to
devm_power_supply_register(), however, so the power supply core cannot
parse power-supplies and the battery never gets a supplier from
firmware. The status lookup then always returns -ENODEV and userspace
sees POWER_SUPPLY_STATUS_UNKNOWN.
Set psy_cfg.fwnode the way max17042_battery and cw2015_battery already
do.
Fixes: f4b782af61ae ("power: max17040: pass status property from supplier")
Assisted-by: Claude:claude-opus-5-5 [Claude Code]
Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.
Best regards,
Krzysztof