Re: [PATCH] software node: only let the owner release a managed node

From: Johan Hovold

Date: Mon Nov 09 2026 - 11:23:15 EST


On Mon, Nov 09, 2026 at 05:08:50PM +0100, Bartosz Golaszewski wrote:
> On Mon, Nov 09, 2026 at 04:55:34PM +0100, Johan Hovold wrote:

> > I've updated the commit with the missing Reviewed-by and Fixes tag. I
> > also decided to drop the reordering of releasing the swnode references
> > as that is arguable an unrelated change and the current code expects
> > users to hold a reference unless it's a managed node.
> >
>
> Ok, I won't be sending a v2 then.
>
> I'm not sure what the workflow is exactly among the driver core maintainers
> but the commit that ended up in tree looks quite different from what
> I submitted and what Link: references.

Right, and the three changes are recorded in the commit trailers (and
the rationale is documented in the Link thread).

> Such in-tree modifications from maintainers have caused problems in the
> past[1]. I would have preferred to apply changes myself based on reviews
> and send a v2 which could then be queued as it appears on the list. Just
> my 2 cents.

Since I've already done the work, and have the context fresh in mind,
another round-trip would just mean even more work.

If you think it differs too much or you don't agree with the end-result,
I can update the authorship.

Johan