Re: [PATCH] software node: only let the owner release a managed node
From: Bartosz Golaszewski
Date: Mon Nov 09 2026 - 11:26:53 EST
On Mon, Nov 09, 2026 at 04:55:34PM +0100, Johan Hovold wrote:
> On Mon, Nov 09, 2026 at 04:17:33PM +0100, Danilo Krummrich wrote:
> > On Mon Nov 9, 2026 at 3:59 PM CET, Johan Hovold wrote:
>
> > > So I think we can just go ahead and fix this in driver core directly.
> >
> > Ok, then I agree it is fine as is. :)
>
> Good. :)
>
> I've updated the commit with the missing Reviewed-by and Fixes tag. I
> also decided to drop the reordering of releasing the swnode references
> as that is arguable an unrelated change and the current code expects
> users to hold a reference unless it's a managed node.
>
Ok, I won't be sending a v2 then.
I'm not sure what the workflow is exactly among the driver core maintainers
but the commit that ended up in tree looks quite different from what
I submitted and what Link: references.
Such in-tree modifications from maintainers have caused problems in the
past[1]. I would have preferred to apply changes myself based on reviews
and send a v2 which could then be queued as it appears on the list. Just
my 2 cents.
Thanks,
Bartosz
[1] https://lore.kernel.org/all/CACMJSesVR_3-PBt1ScricSKNMRzH5gesqtTVW3mqN=gg0-O-7w@xxxxxxxxxxxxxx/