Re: [PATCH v2 03/10] ASoC: fsl_sai: Remove redundant error messages

[Mark Brown]

On Mon, Nov 09, 2026 at 11:08:05AM +0700, Bui Duc Phuc wrote:

> > >       ret = devm_request_irq(dev, irq, fsl_sai_isr, IRQF_SHARED,
> > >                              np->name, sai);
> > > -     if (ret) {
> > > -             dev_err(dev, "failed to claim irq %u\n", irq);
> > > +     if (ret)
> > >               goto err_pm_get_sync;
> > > -     }

> > This will only print an error for a subset of errors, things like -EBUSY
> > will now silently fail.

> From what I can see in the code, devm_request_irq() ->
> devm_request_threaded_irq() reports every failure via dev_err_probe()
> in devm_request_result(), so -EBUSY should be printed too.

Ah, that's changed since I last looked.

> Or did you mean fsl_sai_read_dlcfg()? It does have some silent
> -EINVAL returns.
> I'll restore that dev_err() together with the fsl_sai_reset_hw()
> change I mentioned earlier.

That too.

Attachment: signature.asc
Description: PGP signature