Re: [PATCH] net: ti: icssg-prueth-sr1: Fix device_node refcount leak in prueth_probe()
From: Simon Horman
Date: Mon Nov 09 2026 - 12:16:50 EST
On Fri, Oct 30, 2026 at 04:58:51PM +0800, laixiangwu wrote:
> prueth_probe() takes references on the eth0_node/eth1_node device nodes
> with of_node_get() and stores them in prueth->eth_node[]. If either of
> the "ti,mii-g-rt" or "ti,mii-rt" syscon regmap lookups fails, probe()
> returns -ENODEV without dropping those references, leaking the device
> nodes.
>
> Jump to the existing put_cores label so the error path releases the
> eth0_node/eth1_node references like all the other failure paths in the
> function do.
>
> Fixes: e654b85a693e ("net: ti: icssg-prueth: Add ICSSG Ethernet driver for AM65x SR1.0 platforms")
> Signed-off-by: laixiangwu <laixiangwu@xxxxxxxxxxxxxxxxxxxx>
Same feedback as for
- [PATCH] net: ti: icssg-prueth: Fix device_node refcount leak in prueth_probe()
https://lore.kernel.org/all/20261030085651.1944-1-laixiangwu@xxxxxxxxxxxxxxxxxxxx/
--
pw-bot: cr