Re: [PATCH] net: ti: icssg-prueth-sr1: Fix device_node refcount leak in prueth_probe()
From: Xiangwu Lai
Date: Mon Nov 09 2026 - 21:44:05 EST
Hi Simon,
Thanks for the feedback.
The SR1.0 driver shares the same port scan loop and the same checks
that follow it, so the same analysis applies: the
eth0_node == eth1_node comparison is dead code for the same reason,
the uninitialised reg value is used when of_property_read_u32()
fails, and the loop can leak references both on duplicate reg
values and on out-of-range ones.
I will fold this fix into the same v2 series as the icssg-prueth
fix, as you suggested, and the port scan loop clean-up will cover
both drivers too.
Best regards,
Xiangwu Lai