Re: [PATCH net-next v2 6/7] dt-bindings: net: adi,adin1110: Add adi,spi-oa-tc6

[Krzysztof Kozlowski]

On Mon, Nov 09, 2026 at 10:59:51AM +0200, Iustin Stolniceanu wrote:
> From: Ciprian Regus <ciprian.regus@xxxxxxxxxx>
> 
> The ADIN1110 and ADIN2111 support two SPI host interface protocols:
> the generic SPI protocol and the OPEN Alliance TC6 protocol. The
> protocol is selected by the state of the SPI_CFG1 pin, which the device
> latches when it comes out of reset, together with SPI_CFG0, which
> selects CRC (generic SPI) or protection (OPEN Alliance) mode.
> 
> The protocol is set by the board hardware, so the driver must know it
> in advance. Add a boolean property to describe a device configured for
> the OPEN Alliance TC6 protocol. Without it, the generic SPI protocol is
> assumed, as before.
> 
> adi,spi-crc enables the CRC of the generic SPI protocol, so it is not
> allowed together with adi,spi-oa-tc6. The OPEN Alliance protection mode
> needs no property, as the driver reads it from the PROTE bit in CONFIG0.
> 
> Signed-off-by: Ciprian Regus <ciprian.regus@xxxxxxxxxx>
> Signed-off-by: Iustin Stolniceanu <iustin.stolniceanu@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/net/adi,adin1110.yaml        | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/adi,adin1110.yaml b/Documentation/devicetree/bindings/net/adi,adin1110.yaml
> index 0a73e01d7f97..fa30787c663d 100644
> --- a/Documentation/devicetree/bindings/net/adi,adin1110.yaml
> +++ b/Documentation/devicetree/bindings/net/adi,adin1110.yaml
> @@ -28,6 +28,12 @@ description: |
>  allOf:
>    - $ref: ethernet-controller.yaml#
>    - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +  - if:
> +      required:
> +        - adi,spi-oa-tc6
> +    then:
> +      properties:
> +        adi,spi-crc: false

Please move the entire allOf to the bottom, after "required:" block.

>  
>  properties:
>    compatible:
> @@ -43,6 +49,12 @@ properties:
>        Enable CRC8 checks on SPI read/writes.
>      type: boolean
>  
> +  adi,spi-oa-tc6:
> +    description: |

Do not need '|' unless you need to preserve formatting.

Best regards,
Krzysztof