Re: [PATCH v4 1/4] x86/boot/compressed: Remove unused variables in EFI helpers

[Ingo Molnar]

* Thorsten Blum <blum@xxxxxxxxxx> wrote:

> efi_get_system_table() declares an unused et variable, and
> efi_get_conf_table() declares an unused ret variable - remove both.
> 
> get_kexec_setup_data() also takes an unused et argument. Drop the
> argument and update the only caller in efi_get_conf_table().
> 
> Also simplify the no EFI system table case in efi_get_system_table() by
> falling through to the existing return since sys_tbl_pa is already zero,
> and add the missing newline to the debug log message.
> 
> Reviewed-by: Jan Stancek <jstancek@xxxxxxxxxx>
> Reviewed-by: Nicolas Schier <n.schier@xxxxxxxxx>
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>

> @@ -70,10 +69,8 @@ unsigned long efi_get_system_table(struct boot_params *bp)
>  #else
>  	sys_tbl_pa = ei->efi_systab;
>  #endif
> -	if (!sys_tbl_pa) {
> -		debug_putstr("EFI system table not found.");
> -		return 0;
> -	}
> +	if (!sys_tbl_pa)
> +		debug_putstr("EFI system table not found.\n");
>  
>  	return sys_tbl_pa;
>  }

Please put unrelated changes into separate patches.

In particular don't make changes that are not reflected in
the title:

  [PATCH v4 1/4] x86/boot/compressed: Remove unused variables in EFI helpers

Having the above change included in a patch with such a title
is highly confusing.

Thanks,

	Ingo