Re: [PATCH 3/8] dt-bindings: media: i2c: Add Samsung S5K3M3 image sensor

From: Krzysztof Kozlowski

Date: Tue Nov 10 2026 - 03:20:04 EST


On Mon, Nov 09, 2026 at 10:38:21PM +0000, Gaurav Suman wrote:
> Add bindings for the Samsung S5K3M3 (ISOCELL 3M3) 13MP sensor, used
> as the wide camera of the LG G8x ThinQ.
>
> This was written and tested with the help of an AI coding assistant
> (Claude Opus 5.5, Anthropic); I reviewed the change and the results.

Drop paragraph, it goes to the changelog, not commit msg. You need to
review better, because it has obvious and trivial misindentation. If you
just copied existing code you would see it is different. Instead of
using existing bindings as base, you just generated new stuff with new
issues.

I might be ignoring your contributions based on that.

>
> Signed-off-by: Gaurav Suman <gauravsuman007@xxxxxxxxx>
> ---
> .../bindings/media/i2c/samsung,s5k3m3.yaml | 104 +++++++++++++++++++++
> 1 file changed, 104 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/samsung,s5k3m3.yaml b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3m3.yaml
> new file mode 100644
> index 0000000000000000000000000000000000000000..434f5d4326b726d0a65288a2a91b750e38a8706e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/samsung,s5k3m3.yaml
> @@ -0,0 +1,104 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/samsung,s5k3m3.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung S5K3M3 Image Sensor
> +
> +description:
> + Samsung S5K3M3 (ISOCELL 3M3) is a 13MP image sensor controlled over a
> + serial camera control bus. The driver supports 4160x3120 at 30 frames per
> + second, RAW10 over a 4-lane MIPI D-PHY interface.

Drop driver.

> +
> +maintainers:
> + - Gaurav Suman <gauravsuman007@xxxxxxxxx>
> +
> +allOf:
> + - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> + compatible:
> + const: samsung,s5k3m3
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + description: MCLK supply clock.
> + maxItems: 1
> +
> + reset-gpios:
> + description: Active low GPIO connected to RESET pad of the sensor.
> + maxItems: 1
> +
> + vdda-supply:
> + description: Analogue voltage supply, 2.8 volts.
> +
> + vddd-supply:
> + description: Digital core voltage supply.
> +
> + vddio-supply:
> + description: Digital I/O voltage supply, 1.8 volts.
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> +
> + required:
> + - data-lanes
> + - link-frequencies
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - reset-gpios
> + - port
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>

Messed indentation.


Best regards,
Krzysztof