Re: [PATCH 3/4] media: i2c: vd55g1: remove redundant pm_runtime_dont_use_autosuspend() calls
From: Benjamin Mugnier
Date: Tue Nov 10 2026 - 09:28:03 EST
Hi Joshua,
Le 10/11/2026 à 15:03, Joshua Crofts a écrit :
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
>
> Remove the redundant function calls.
>
> Signed-off-by: Joshua Crofts <crofts@xxxxxxxxxx>
That's an easy one. Thank you.
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>
> ---
> drivers/media/i2c/vd55g1.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
> index 3a3ce32b0610eb23d42b622f2173a505df120176..8ea68dc9b1d99d11a7678138a5b6f7147b595f0a 100644
> --- a/drivers/media/i2c/vd55g1.c
> +++ b/drivers/media/i2c/vd55g1.c
> @@ -2053,7 +2053,6 @@ static int vd55g1_probe(struct i2c_client *client)
> err_power_off:
> pm_runtime_disable(dev);
> pm_runtime_put_noidle(dev);
> - pm_runtime_dont_use_autosuspend(dev);
> vd55g1_power_off(dev);
>
> return ret;
> @@ -2070,7 +2069,6 @@ static void vd55g1_remove(struct i2c_client *client)
> if (!pm_runtime_status_suspended(&client->dev))
> vd55g1_power_off(&client->dev);
> pm_runtime_set_suspended(&client->dev);
> - pm_runtime_dont_use_autosuspend(&client->dev);
> }
>
> static const struct of_device_id vd55g1_dt_ids[] = {
>
--
Regards,
Benjamin