Re: [PATCH v2 3/3] rust: bitmap: kunit: uncomment owned_bitmap_out_of_bounds panic case

[Nicolás Antinori]

On Sun Nov 8, 2026 at 4:59 PM -03, Miguel Ojeda wrote:
> On Thu, Oct 29, 2026 at 5:59 PM Nicolás Antinori via B4 Relay
> <devnull+nico.antinori.7.gmail.com@xxxxxxxxxx> wrote:
>>
>> -    #[test]
>>      #[cfg(not(CONFIG_RUST_BITMAP_HARDENED))]
>> +    #[test]
>
> Is this one done to match the other? If so, please mention it in the
> commit message, and consider whether the last test in the file should
> also be changed then.

Yes! it was to match the other one. Since there are more tests the other
way (#[test] on top) I can change the one I am uncommenting! (kunit.rs
have also the #[test] attributes on top where a #[cfg(..)] is present).

>
> (We could do it in a separate, previous commit, but that is nit :)
>
>>          let mut b = BitmapVec::new(128, GFP_KERNEL)?;
>> -
>>          b.set_bit(2048);
>
> Spurious change?

It was on purpose, I thought it looked tidier separating it (but it is
just personal taste :P, gonna revert this in the v3)

>
>> +    #[should_panic]
>
> It is great to have this, thanks! :)
>
> Cheers,
> Miguel