Re: [PATCH v2 3/3] rust: bitmap: kunit: uncomment owned_bitmap_out_of_bounds panic case

[Miguel Ojeda]

On Tue, Nov 10, 2026 at 2:50 PM Nicolás Antinori
<nico.antinori.7@xxxxxxxxx> wrote:
>
> Yes! it was to match the other one. Since there are more tests the other
> way (#[test] on top) I can change the one I am uncommenting! (kunit.rs
> have also the #[test] attributes on top where a #[cfg(..)] is present).

Yeah, then let's use the existing convention -- that other change can
be done in a separate patch if someone wants to do it.

> It was on purpose, I thought it looked tidier separating it (but it is
> just personal taste :P, gonna revert this in the v3)

So we generally try to avoid those unrelated changes, though sometimes
it is just easier to do in the same patch.

However, I was asking because that removed the line (and you say here
"separating") while later you instead keep it in
`owned_bitmap_out_of_bounds`, so I assumed it was an unexpected
change.

Either way, yeah, it is best to not include unrelated changes to avoid
confusion.

Thanks!

Cheers,
Miguel