Re: [PATCH v5 1/2] dt-bindings: i2c: Add Synopsys DWC_i2c controller

[Krzysztof Kozlowski]

On Wed, Nov 11, 2026 at 12:05:15AM +0000, Mark Brown wrote:
> On Wed, Nov 11, 2026 at 02:05:48AM +0530, Aniket Limaye wrote:
> > Add documentation for the Synopsys Advanced I2C (DWC_i2c) controller, as
> > found on the TI TDA54 SoC.
> 
> > The block cannot work on its own and needs SoC integration, e.g. the
> > FIFO depths are not discoverable from the IP. Do not add a generic
> > compatible and only list SoC specific compatibles. The file is named
> > after the IP so that other SoCs integrating it can be added here.
> 
> I still think we should have a fallback compatible here, while we can't
> discover the FIFO depths all the uses have a programmed trigger and we
> know the minimum depth configurable in the IP so we can fall back to
> using that.  This would be useful for distro kernels, it's one less
> thing that forces using a kernel with specific SoC support.

If the driver does not match on such generic compatible - and that's my
impression from commit msg -  then it is pretty useless.

Best regards,
Krzysztof