Re: [PATCH v5 1/2] dt-bindings: i2c: Add Synopsys DWC_i2c controller
From: Mark Brown
Date: Wed Nov 11 2026 - 08:37:11 EST
On Wed, Nov 11, 2026 at 09:41:40AM +0100, Krzysztof Kozlowski wrote:
> On Wed, Nov 11, 2026 at 12:05:15AM +0000, Mark Brown wrote:
> > I still think we should have a fallback compatible here, while we can't
> > discover the FIFO depths all the uses have a programmed trigger and we
> > know the minimum depth configurable in the IP so we can fall back to
> > using that. This would be useful for distro kernels, it's one less
> > thing that forces using a kernel with specific SoC support.
> If the driver does not match on such generic compatible - and that's my
> impression from commit msg - then it is pretty useless.
The driver can match on a generic compatible, it just doesn't right now.
It's getting the FIFO depth from the compatible but as I observe above
the minimum FIFO depth is known so we can just use that as the fallback,
we program the trigger points for the FIFO so it doesn't matter if there
is more space than we're using.
Attachment:
signature.asc
Description: PGP signature