Re: [PATCH net-next v1 05/11] xsk: Install UMEM page pool providers in the core
From: Björn Töpel
Date: Wed Nov 11 2026 - 09:10:04 EST
Stanislav Fomichev <sdf.kernel@xxxxxxxxx> writes:
> On 11/10, Björn Töpel wrote:
>> diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
>> index 18966bbdb5b7..c620a0c32c17 100644
>> --- a/net/xdp/xsk_buff_pool.c
>> +++ b/net/xdp/xsk_buff_pool.c
>> @@ -104,10 +101,30 @@ struct xsk_buff_pool *xp_create_and_assign_umem(struct xdp_sock *xs,
>> pool->fq = xs->fq_tmp;
>> pool->cq = xs->cq_tmp;
>>
>> - for (i = 0; i < pool->free_heads_cnt; i++) {
>> + return pool;
>> +
>> +out:
>> + xp_destroy(pool);
>> + return NULL;
>> +}
>> +
>> +/* Only copy mode and driver zero copy use heads */
>> +int xp_alloc_heads(struct xsk_buff_pool *pool)
>
> nit: move xp_alloc_heads rework into a separate patch? this one is quite
> big already
Will do!
Björn