Re: [PATCH v2] drm/vc4: release firmware on error paths in vc4_hvs_bind()

From: Maíra Canal

Date: Wed Nov 11 2026 - 09:10:45 EST


Hi Dan,

On 11/11/26 10:45, Dan Carpenter wrote:
On Wed, Nov 11, 2026 at 02:15:28PM +0100, Tomasz Unger wrote:
So without the patch every failed bind leaks one reference, and with the
patch the reference is dropped.

Tested-by: Tomasz Unger <tomasz.unger@xxxxxxxx>

One note about the Fixes tag: 2fa4ef5fb943 only moved this code around.
As far as I can tell, the rpi_firmware_get() before devm_clk_get()
without a put on the error path was introduced by commit 2a001ca00ad5
("drm/vc4: hdmi: Rework hdmi_enable_4kp60 detection code"), which went
into v6.2.

Huh. Wow. Thanks. I'll resend the patch with the correct Fixes tag.

A patch addressing this issue is already queued for this week's drm PR
[1]. Sorry for letting your patch slip through the cracks.

[1] https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/af200e91c7b996177aa90981b2f0e794b085d43a

Best regards,
- Maíra


regards,
dan carpenter