Re: [PATCH v8 02/29] drm/msm/dp: add support to send ACT packets for MST
From: Dmitry Baryshkov
Date: Wed Nov 11 2026 - 09:47:33 EST
On Tue, Nov 10, 2026 at 12:54:23PM +0800, Yongxing Mou wrote:
> From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
>
> Whenever virtual channel slot allocation changes, the DP
> source must send the action control trigger sequence to notify
> the sink about the same. This would be applicable during the
> start and stop of the pixel stream. Add the infrastructure
> to be able to send ACT packets for the DP controller when
> operating in MST mode.
>
> Add REG_DP_MST_ACT, the ACT trigger register used by this sequence.
>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/dp/dp_ctrl.c | 44 ++++++++++++++++++++++++++++++++++++-
> drivers/gpu/drm/msm/dp/dp_ctrl.h | 5 ++++-
> drivers/gpu/drm/msm/dp/dp_display.c | 3 ++-
> drivers/gpu/drm/msm/dp/dp_display.h | 1 +
> drivers/gpu/drm/msm/dp/dp_reg.h | 1 +
> 5 files changed, 51 insertions(+), 3 deletions(-)
>
Is Sashiko comment valid? Otherwise LGTM.
--
With best wishes
Dmitry