Re: [PATCH v8 02/29] drm/msm/dp: add support to send ACT packets for MST

From: Yongxing Mou

Date: Wed Nov 11 2026 - 21:29:51 EST




On 11/11/2026 10:41 PM, Dmitry Baryshkov wrote:
On Tue, Nov 10, 2026 at 12:54:23PM +0800, Yongxing Mou wrote:
From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

Whenever virtual channel slot allocation changes, the DP
source must send the action control trigger sequence to notify
the sink about the same. This would be applicable during the
start and stop of the pixel stream. Add the infrastructure
to be able to send ACT packets for the DP controller when
operating in MST mode.

Add REG_DP_MST_ACT, the ACT trigger register used by this sequence.

Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
---
drivers/gpu/drm/msm/dp/dp_ctrl.c | 44 ++++++++++++++++++++++++++++++++++++-
drivers/gpu/drm/msm/dp/dp_ctrl.h | 5 ++++-
drivers/gpu/drm/msm/dp/dp_display.c | 3 ++-
drivers/gpu/drm/msm/dp/dp_display.h | 1 +
drivers/gpu/drm/msm/dp/dp_reg.h | 1 +
5 files changed, 51 insertions(+), 3 deletions(-)


Is Sashiko comment valid? Otherwise LGTM.

The comment is valid, but the issue was not introduced by this patch. It was introduced by "38e4b12149792 drm/msm/dp: move the pixel clock control to its own API".

Would you prefer a separate change to fix this issue, or should I fix it directly in this patch? If the latter, I’ll try to send the next version soon to keep this series moving forward.