Re: [PATCH v8 08/29] drm/msm/dp: replace power_on with active_stream_mask
From: Dmitry Baryshkov
Date: Wed Nov 11 2026 - 09:48:27 EST
On Tue, Nov 10, 2026 at 12:54:29PM +0800, Yongxing Mou wrote:
> From: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
>
> The power_on boolean cannot represent DP MST, where multiple streams
> share a single link and its associated resources.
>
> Replace power_on with active_stream_mask, a bitmask of the streams that
> have been successfully enabled, and use it to track the lifetime of the
> shared link. Link initialization is performed when enabling the first
> stream, while link teardown is deferred until the last stream is
> disabled.
>
> A per-stream bit rather than a count is needed because two callers ask
> whether one specific stream is up: msm_dp_display_disable() uses it to
> stay idempotent, and msm_dp_display_disable_helper() uses it to tell
> whether that stream ever made it through .atomic_enable().
>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>
> Signed-off-by: Yongxing Mou <yongxing.mou@xxxxxxxxxxxxxxxx>
> ---
> drivers/gpu/drm/msm/dp/dp_audio.c | 2 +-
> drivers/gpu/drm/msm/dp/dp_display.c | 56 ++++++++++++++++++++-----------------
> drivers/gpu/drm/msm/dp/dp_display.h | 2 +-
> 3 files changed, 32 insertions(+), 28 deletions(-)
>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
--
With best wishes
Dmitry