[PATCH 2/2] nvmet: use overflow-safe range checks in the file backend
From: shao.mingyin
Date: Wed Nov 11 2026 - 09:48:27 EST
From: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
The file backend shifts a host-supplied SLBA to form a byte offset
before checking it against the namespace size. The shift can discard
high bits: with a 4 KiB block size, SLBA 2^52 + 1 becomes offset 4096.
The range check then accepts a command aimed outside the namespace and
the backend accesses data at the wrapped offset.
Reject overflowing LBA-to-byte conversions and check the transfer
length against the remaining namespace size without adding it to the
offset. Apply the checks to reads, writes, discard and write zeroes.
Fixes: 9c891c139894 ("nvmet: check fileio lba range access boundaries")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
---
Tested on 7.3.0-next-20261030 (QEMU/TCG guest) with the loop transport
and a 4 MiB file-backed namespace.
A Write with SLBA = 2^52 + 1 and a 4 KiB block size yields a byte
offset that wraps to 0x1000 and passes the size check:
unpatched patched
ret=0 (write accepted at 0x1000) ret=24705 (Capacity Exceeded)
drivers/nvme/target/io-cmd-file.c | 41 +++++++++++++++++++++++++++----------
1 file changed, 30 insertions(+), 11 deletions(-)
diff --git a/drivers/nvme/target/io-cmd-file.c b/drivers/nvme/target/io-cmd-file.c
index 695963dd932e..d59dbf61b1b0 100644
--- a/drivers/nvme/target/io-cmd-file.c
+++ b/drivers/nvme/target/io-cmd-file.c
@@ -125,17 +125,22 @@ static bool nvmet_file_execute_io(struct nvmet_req *req, int ki_flags)
size_t len = 0, total_len = 0;
ssize_t ret = 0;
loff_t pos;
+ u64 pos64;
int i;
struct scatterlist *sg;
if (req->f.mpool_alloc && nr_bvec > NVMET_MAX_MPOOL_BVEC)
is_sync = true;
- pos = le64_to_cpu(req->cmd->rw.slba) << req->ns->blksize_shift;
- if (unlikely(pos + req->transfer_len > req->ns->size)) {
+ if (unlikely(check_shl_overflow(le64_to_cpu(req->cmd->rw.slba),
+ req->ns->blksize_shift,
+ &pos64) ||
+ pos64 > req->ns->size ||
+ req->transfer_len > req->ns->size - pos64)) {
ret = -ENOSPC;
goto complete;
}
+ pos = pos64;
memset(&req->f.iocb, 0, sizeof(struct kiocb));
for_each_sg(req->sg, sg, req->sg_cnt, i) {
@@ -269,6 +274,16 @@ static void nvmet_file_execute_flush(struct nvmet_req *req)
queue_work(nvmet_wq, &req->f.work);
}
+static bool nvmet_file_check_lba_range(struct nvmet_req *req, u64 slba,
+ u64 nlb, u64 *offset, u64 *len)
+{
+ if (check_shl_overflow(slba, req->ns->blksize_shift, offset) ||
+ check_shl_overflow(nlb, req->ns->blksize_shift, len))
+ return false;
+
+ return *offset <= req->ns->size && *len <= req->ns->size - *offset;
+}
+
static void nvmet_file_execute_discard(struct nvmet_req *req)
{
int mode = FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE;
@@ -279,19 +294,22 @@ static void nvmet_file_execute_discard(struct nvmet_req *req)
int i;
for (i = 0; i <= le32_to_cpu(req->cmd->dsm.nr); i++) {
+ u64 offset64, len64;
+
status = nvmet_copy_from_sgl(req, i * sizeof(range), &range,
sizeof(range));
if (status)
break;
- offset = le64_to_cpu(range.slba) << req->ns->blksize_shift;
- len = le32_to_cpu(range.nlb);
- len <<= req->ns->blksize_shift;
- if (offset + len > req->ns->size) {
+ if (!nvmet_file_check_lba_range(req, le64_to_cpu(range.slba),
+ le32_to_cpu(range.nlb),
+ &offset64, &len64)) {
req->error_slba = le64_to_cpu(range.slba);
status = errno_to_nvme_status(req, -ENOSPC);
break;
}
+ offset = offset64;
+ len = len64;
ret = vfs_fallocate(req->ns->file, mode, offset, len);
if (ret && ret != -EOPNOTSUPP) {
@@ -336,16 +354,17 @@ static void nvmet_file_write_zeroes_work(struct work_struct *w)
int mode = FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE;
loff_t offset;
loff_t len;
+ u64 offset64, len64;
int ret;
- offset = le64_to_cpu(write_zeroes->slba) << req->ns->blksize_shift;
- len = (((sector_t)le16_to_cpu(write_zeroes->length) + 1) <<
- req->ns->blksize_shift);
-
- if (unlikely(offset + len > req->ns->size)) {
+ if (!nvmet_file_check_lba_range(req, le64_to_cpu(write_zeroes->slba),
+ (u64)le16_to_cpu(write_zeroes->length) + 1,
+ &offset64, &len64)) {
nvmet_req_complete(req, errno_to_nvme_status(req, -ENOSPC));
return;
}
+ offset = offset64;
+ len = len64;
ret = vfs_fallocate(req->ns->file, mode, offset, len);
nvmet_req_complete(req, ret < 0 ? errno_to_nvme_status(req, ret) : 0);