Re: [PATCH v8 5/8] arm64: dts: qcom: sm8250: Add JPEG encoder node

From: Atanas Filipov

Date: Wed Nov 11 2026 - 10:43:28 EST


On Wed, Nov 11, 2026 at 03:14:54PM +0200, Dmitry Baryshkov wrote:
> > + jpeg_enc: jpeg-encoder@ac53000 {
> > + compatible = "qcom,sm8250-jpeg-enc";
> > + status = "disabled";
>
> Drop, there is no point in keeping it disabled. (And the status is
> expected to be the last property anyway).

Ok, I will enable it by default in the next version.

> > + power-domains = <&camcc TITAN_TOP_GDSC>,
>
> TITAN_TOP_GDSC is a child of MMCX. You shouldn't need to declare mmcx
> separately. Instead cast the votes on TITAN and they will propagate to
> the MMCX rail.

Ok, I will drop mmcx and vote through TITAN_TOP_GDSC.

> > + interconnects = <&mmss_noc MASTER_CAMNOC_SF 0 &mc_virt SLAVE_EBI_CH0 0>;
>
> Use tags instead of 0. I guess it's QCOM_ICC_TAG_ALWAYS.

Ok, I will use QCOM_ICC_TAG_ALWAYS.

--
Best regards,
Atanas