Re: [PATCH v8 5/8] arm64: dts: qcom: sm8250: Add JPEG encoder node
From: Dmitry Baryshkov
Date: Wed Nov 11 2026 - 08:21:39 EST
On Tue, Nov 10, 2026 at 06:39:06PM +0200, Atanas Filipov wrote:
> Add the JPEG encoder hardware node to the SM8250 device tree so the
> qcom-jpeg V4L2 encoder driver can bind and operate on this platform.
>
> Signed-off-by: Atanas Filipov <atanas.filipov@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 72 ++++++++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index f975c2183269a..7e8447df40188 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -4480,6 +4480,78 @@ cci1_i2c1: i2c-bus@1 {
> };
> };
>
> + jpeg_enc: jpeg-encoder@ac53000 {
> + compatible = "qcom,sm8250-jpeg-enc";
> + status = "disabled";
Drop, there is no point in keeping it disabled. (And the status is
expected to be the last property anyway).
> +
> + reg = <0x0 0x0ac53000 0x0 0x1000>;
> +
> + interrupts = <GIC_SPI 474 IRQ_TYPE_EDGE_RISING>;
> +
> + power-domains = <&camcc TITAN_TOP_GDSC>,
TITAN_TOP_GDSC is a child of MMCX. You shouldn't need to declare mmcx
separately. Instead cast the votes on TITAN and they will propagate to
the MMCX rail.
> + <&rpmhpd RPMHPD_MX>,
> + <&rpmhpd RPMHPD_MMCX>;
> + power-domain-names = "titan_top", "mx", "mmcx";
> +
> +
> + interconnects = <&mmss_noc MASTER_CAMNOC_SF 0 &mc_virt SLAVE_EBI_CH0 0>;
Use tags instead of 0. I guess it's QCOM_ICC_TAG_ALWAYS.
> + interconnect-names = "camnoc";
> +
> + iommus = <&apps_smmu 0x2040 0x400>;
> +
> + operating-points-v2 = <&jpeg_opp_table>;
> +
> + jpeg_opp_table: opp-table {
> + compatible = "operating-points-v2";
> +
> + opp-100000000 {
> + opp-hz = /bits/ 64 <100000000>;
> + opp-peak-kBps = <262560>;
> + required-opps = <&rpmhpd_opp_svs_l1>,
> + <&rpmhpd_opp_low_svs>;
> + };
> +
> + opp-200000000 {
> + opp-hz = /bits/ 64 <200000000>;
> + opp-peak-kBps = <524760>;
> + required-opps = <&rpmhpd_opp_svs_l1>,
> + <&rpmhpd_opp_svs>;
> + };
> +
> + opp-400000000 {
> + opp-hz = /bits/ 64 <400000000>;
> + opp-peak-kBps = <978600>;
> + required-opps = <&rpmhpd_opp_svs_l1>,
> + <&rpmhpd_opp_svs_l1>;
> + };
> +
> + opp-480000000 {
> + opp-hz = /bits/ 64 <480000000>;
> + opp-peak-kBps = <1095600>;
> + required-opps = <&rpmhpd_opp_svs_l1>,
> + <&rpmhpd_opp_nom>;
> + };
> +
> + opp-600000000 {
> + opp-hz = /bits/ 64 <600000000>;
> + opp-peak-kBps = <1095600>;
> + required-opps = <&rpmhpd_opp_svs_l1>,
> + <&rpmhpd_opp_turbo>;
> + };
> + };
> + };
> +
> camss: camss@ac6a000 {
> compatible = "qcom,sm8250-camss";
> status = "disabled";
> --
> 2.34.1
>
--
With best wishes
Dmitry