Re: [PATCH v8 7/8] arm64: dts: qcom: kodiak: Add JPEG encoder node
From: Atanas Filipov
Date: Wed Nov 11 2026 - 11:07:32 EST
On Wed, Nov 11, 2026 at 03:17:53PM +0200, Dmitry Baryshkov wrote:
> > + status = "disabled";
>
> Same comment. Enable it by default.
Ok, the same as for SM8250.
> > + power-domains = <&camcc CAM_CC_TITAN_TOP_GDSC>,
> > + <&rpmhpd SC7280_CX>;
> > + power-domain-names = "titan_top", "cx";
>
> The same, drop cx. Also the PLLs on Kodiak are clocked by MX domain, so
> MX should be listed here (and used to cast required votes on the MX
> rail).
On SC7280 this is different from SM8250. The camcc node has no
power-domains property, and the sc7280-camcc binding does not allow
one. In camcc-sc7280.c, cam_cc_titan_top_gdsc has no parent. So
TITAN_TOP_GDSC is not a child of CX, and a vote on TITAN_TOP_GDSC does
not reach the CX rail.
I see two options:
1. Keep cx in the JPEG node.
2. Add CX as the power domain of camcc (binding and DT change), and
then drop cx from the JPEG node.
Which one do you prefer?
About MX: Ok, I will add it.
--
Best regards,
Atanas