Re: [PATCH v2 05/12] sched/core: Abstract/fix rq_clock_start_loop_update()
From: Peter Zijlstra
Date: Wed Nov 11 2026 - 12:02:40 EST
On Mon, Nov 09, 2026 at 01:26:24AM +0300, Kayra Cizmeci wrote:
> > struct rq_flags {
> > @@ -1938,14 +1949,14 @@ static inline void rq_pin_lock(struct rq
> > {
> > rf->cookie = lockdep_pin_lock(__rq_lockp(rq));
> >
> > - rq->clock_update_flags &= (RQCF_REQ_SKIP|RQCF_ACT_SKIP);
> > + rq->clock_update_flags &= ~RQCF_UPDATED;
> > rf->clock_update_flags = 0;
> > assert_balance_callbacks_empty(rq);
> > }
>
> Ah you changed it here. So I guess you forgot to change it in
> double_rq_clock_clear_update(), no? :-).
Yes, I managed to completely overlook that function. Grep must've been
broken that day :-)
I typically use telescope-git-grep.nvim, oh well.