Re: [PATCH v2 6/6] spi: cadence-xspi: Add workaround for old Marvell firmwares

[kernel test robot]

Hi Paul,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on linus/master v7.4-rc2 next-20261110]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Paul-Cercueil/spi-cadence-xspi-Properly-handle-errors-in-transfer_one_message/20261111-113536
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20261111103541.100848-7-paul.cercueil%40bootlin.com
patch subject: [PATCH v2 6/6] spi: cadence-xspi: Add workaround for old Marvell firmwares
config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20261112/202611121026.JlDpURlH-lkp@xxxxxxxxx/config)
compiler: nios2-linux-gcc (GCC) 11.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261112/202611121026.JlDpURlH-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611121026.JlDpURlH-lkp@xxxxxxxxx/

All error/warnings (new ones prefixed by >>):

>> drivers/spi/spi-cadence-xspi.c:1234:40: error: array type has incomplete element type 'struct acpi_platform_list'
    1234 | static const struct acpi_platform_list mrvl_platform_list[] = {
         |                                        ^~~~~~~~~~~~~~~~~~
>> drivers/spi/spi-cadence-xspi.c:1239:25: error: 'all_versions' undeclared here (not in a function)
    1239 |                 .pred = all_versions,
         |                         ^~~~~~~~~~~~
   drivers/spi/spi-cadence-xspi.c: In function 'cdns_is_marvell':
>> drivers/spi/spi-cadence-xspi.c:1249:24: error: implicit declaration of function 'acpi_match_platform_list' [-Werror=implicit-function-declaration]
    1249 |                 return acpi_match_platform_list(mrvl_platform_list) >= 0;
         |                        ^~~~~~~~~~~~~~~~~~~~~~~~
   At top level:
>> drivers/spi/spi-cadence-xspi.c:1234:40: warning: 'mrvl_platform_list' defined but not used [-Wunused-variable]
    1234 | static const struct acpi_platform_list mrvl_platform_list[] = {
         |                                        ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +1234 drivers/spi/spi-cadence-xspi.c

  1233	
> 1234	static const struct acpi_platform_list mrvl_platform_list[] = {
  1235		{
  1236			.oem_id = "MRVL  ",
  1237			.oem_table_id = "CN10K",
  1238			.table = ACPI_SIG_DSDT,
> 1239			.pred = all_versions,
  1240		},
  1241		{ }
  1242	};
  1243	
  1244	static inline bool cdns_is_marvell(struct device *dev)
  1245	{
  1246		const char *compatible;
  1247	
  1248		if (has_acpi_companion(dev))
> 1249			return acpi_match_platform_list(mrvl_platform_list) >= 0;
  1250	
  1251		if (of_machine_read_compatible(&compatible, 0) < 0)
  1252			return false; /* shouldn't actually happen */
  1253	
  1254		return strstarts(compatible, "marvell,");
  1255	}
  1256	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki