Re: [PATCH v15 18/35] firmware: arm_scmi: Add Telemetry DataEvent read capabilities
From: Jonathan Cameron
Date: Wed Nov 11 2026 - 23:36:52 EST
On Mon, 9 Nov 2026 09:12:04 +0000
Cristian Marussi <cristian.marussi@xxxxxxx> wrote:
> Add support for Telemetry operations needed to read DataEvent values and
> timestamps as single entities or all together in a single bulk buffer.
> The returned values are effectiely retrieved from the platform only
> when strictly needed, i.e. when no fresh recent cached value was already
> available.
> The DataEvent values are fetched transparently from the platform origins
> using the proper synchronization and consistency primitives, directly from
> the SHMTIs areas or the FastChannels memory depending on the configuration.
>
> Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
> +static int scmi_telemetry_des_sample_get(const struct scmi_protocol_handle *ph,
> + int grp_id, unsigned int *num_samples,
> + struct scmi_telemetry_de_sample *samples)
> +{
> + struct telemetry_info *ti = ph->get_priv(ph);
> + struct scmi_msg_telemetry_config_set *msg;
> + struct scmi_xfer *t;
> + bool is_group;
> + u32 control;
> + int ret;
> +
> + if (!ti->info.enabled || !num_samples || !samples ||
> + !ti->info.single_read_support)
Trivial but I think if it's not supported we should return appropriate error
to indicate that rather than -EINVAL.
> + return -EINVAL;
> +