Re: [PATCH v3 3/6] ASoC: soc-acpi: move common function topology helpers

[Syed Saba Kareem]

On 11/12/26 00:04, Mark Brown wrote:
> > Move the Intel function topology helpers and the topology device enum
> > to soc-acpi so that they can be shared with other platforms too. The
> > moved helpers are:
> > index 2ee303b791dc..aea47a42f43d 100644
> > --- a/include/sound/soc-acpi.h
> > +++ b/include/sound/soc-acpi.h
> > @@ -257,4 +257,29 @@ bool snd_soc_acpi_sdw_link_slaves_found(struct device *dev,
> >   					const struct snd_soc_acpi_link_adr *link,
> >   					struct sdw_peripherals *peripherals);
> >   
> > +enum tplg_device_id {
> > +	TPLG_DEVICE_SDCA_JACK,
> > +	TPLG_DEVICE_SDCA_AMP,
> > +	TPLG_DEVICE_SDCA_MIC,
> > +	TPLG_DEVICE_INTEL_PCH_DMIC,
> > +	TPLG_DEVICE_HDMI,
> > +	TPLG_DEVICE_SSP_JACK,
> > +	TPLG_DEVICE_SSP_AMP,
> > +	TPLG_DEVICE_SSP_BT,
> > +	TPLG_DEVICE_SSP_HDMI_IN,
> > +	TPLG_DEVICE_LOOPBACK_VIRTUAL,
> > +	TPLG_DEVICE_ACP_SDW_JACK,
> > +	TPLG_DEVICE_ACP_SDW_AMP,
> > +	TPLG_DEVICE_ACP_SDW_MIC,
> > +	TPLG_DEVICE_ACP_DMIC,
> > +	TPLG_DEVICE_MAX
> > +};
> Might be sensible to have some namespacing as part of this move (eg,
> adding an ACPI prefix).
Noted will add.
> >   config SND_SOC_ACPI_INTEL_MATCH
> >   	tristate
> > -	select SND_SOC_ACPI if ACPI
> > +	select SND_SOC_ACPI
> This seems likely to cause issues on systems without ACPI, perhaps this
> should just depend on ACPI?  !ACPI builds are pure coverage testing for
> x86, they're not practical.
Agreed , we will fix and re-spin the patch series.