Re: [PATCH v16 7/9] clk: realtek: Add RTD1625-CRT clock controller driver
From: Brian Masney
Date: Thu Nov 12 2026 - 12:23:07 EST
> Add support for the CRT (Clock, Reset, and Test) domain clock controller
> on the Realtek RTD1625 SoC. This driver provides essential clock sources
> (including PLLs), gating, and multiplexing functionalities for the
> platform's peripherals.
>
> Because the reset controller shares the same register space with this
> CRT clock controller, this driver also acts as the parent device and
> registers the reset controller as an auxiliary device on the auxiliary
> bus.
>
> Signed-off-by: Cheng-Yu Lee <cylee12@xxxxxxxxxxx>
> Co-developed-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> Signed-off-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> ---
> Changes in v16:
> - Remove Brian's reviewed-by tag.
> - Replace 'const char *' parent arrays with 'struct clk_hw *' arrays.
> - Switch all gate, mux, and fixed-factor clock initializations to use '_HW' macros.
> - Use 'CLK_HW_INIT_FW_NAME' for regmap_pll initialization when referencing external
> clocks, and add 'expected_parent_rate' to ensure a safe input rate.
> - Refactor eMMC PLL initialization (decoupling phases and appending rate tables).
> ---
> +static int rtd1625_crt_probe(struct platform_device *pdev)
> +{
> + const struct rtk_clk_desc *desc;
> +
> + desc = device_get_match_data(&pdev->dev);
> + if (!desc)
> + return -EINVAL;
> +
> + return rtk_clk_probe(pdev, desc);
> +}
> +
> +static const struct of_device_id rtd1625_crt_match[] = {
> + { .compatible = "realtek,rtd1625-crt-clk", .data = &rtd1625_crt_desc, },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, rtd1625_crt_match);
> +
> +static struct platform_driver rtd1625_crt_driver = {
> + .probe = rtd1625_crt_probe,
> + .driver = {
> + .name = "rtk-rtd1625-crt-clk",
> + .of_match_table = rtd1625_crt_match,
> + },
Should .suppress_bind_attrs = true similar to what you have in patch 8?
Brian
--
Brian Masney <masneyb@xxxxxxxxxx>